Comments on: The Importance Of Releasing Your Components Through Windsor http://elegantcode.com/2008/12/13/the-importance-of-releasing-your-components-through-windsor/?utm_source=rss&utm_medium=rss&utm_campaign=the-importance-of-releasing-your-components-through-windsor Sun, 12 Feb 2012 18:54:00 +0000 hourly 1 http://wordpress.org/?v=3.0.5 By: Elegant Code » The Component Burden http://elegantcode.com/2008/12/13/the-importance-of-releasing-your-components-through-windsor/comment-page-1/#comment-39660 Elegant Code » The Component Burden Sun, 14 Dec 2008 12:45:47 +0000 http://elegantcode.com/?p=1686#comment-39660 [...] prompted the following comment by Bryan Watts: So Controller is responsible for disposing of something it did not explicitly [...] [...] prompted the following comment by Bryan Watts: So Controller is responsible for disposing of something it did not explicitly [...]

]]> By: The Inquisitive Coder - Davy Brion’s Blog » Blog Archive » The Component Burden http://elegantcode.com/2008/12/13/the-importance-of-releasing-your-components-through-windsor/comment-page-1/#comment-39659 The Inquisitive Coder - Davy Brion’s Blog » Blog Archive » The Component Burden Sun, 14 Dec 2008 12:37:31 +0000 http://elegantcode.com/?p=1686#comment-39659 [...] prompted the following comment by Bryan Watts: So Controller is responsible for disposing of something it did not explicitly [...] [...] prompted the following comment by Bryan Watts: So Controller is responsible for disposing of something it did not explicitly [...]

]]> By: Bryan Watts http://elegantcode.com/2008/12/13/the-importance-of-releasing-your-components-through-windsor/comment-page-1/#comment-39632 Bryan Watts Sat, 13 Dec 2008 23:38:23 +0000 http://elegantcode.com/?p=1686#comment-39632 So Controller is responsible for disposing of something it did not explicitly create? That's a little presumptuous isn't it? > if you own a reference to an IDisposable instance, you are responsible for properly disposing of that instance. I agree (and I've read your other article). However, in this case, Controller clearly does not own its dependency. So Controller is responsible for disposing of something it did not explicitly create? That’s a little presumptuous isn’t it?

> if you own a reference to an IDisposable instance, you are responsible for properly disposing of that instance.

I agree (and I’ve read your other article). However, in this case, Controller clearly does not own its dependency.

]]> By: Davy Brion http://elegantcode.com/2008/12/13/the-importance-of-releasing-your-components-through-windsor/comment-page-1/#comment-39613 Davy Brion Sat, 13 Dec 2008 19:50:08 +0000 http://elegantcode.com/?p=1686#comment-39613 Sergio: well the tests were just an example to highlight the problem and the solution. In the real application code, i ask the container for an instance of the correct controller in the constructor of my base asp.net page. Then when the Dispose method of that base page is called, i release it again. As for my service layer, i request an instance of the correct RequestHandler, i delegate to that handler and right after that i call release it. and that did fix the memory leak Sergio: well the tests were just an example to highlight the problem and the solution. In the real application code, i ask the container for an instance of the correct controller in the constructor of my base asp.net page. Then when the Dispose method of that base page is called, i release it again.

As for my service layer, i request an instance of the correct RequestHandler, i delegate to that handler and right after that i call release it.

and that did fix the memory leak

]]> By: Sergio Pereira http://elegantcode.com/2008/12/13/the-importance-of-releasing-your-components-through-windsor/comment-page-1/#comment-39601 Sergio Pereira Sat, 13 Dec 2008 16:33:56 +0000 http://elegantcode.com/?p=1686#comment-39601 So where did you finally put that container.Release(controller) statement? Having that in your tests in nice but it certainly did not fix your memory leak, right? I'm just concerned with who needs to know about the container and the controller at the same time. So where did you finally put that container.Release(controller) statement? Having that in your tests in nice but it certainly did not fix your memory leak, right? I’m just concerned with who needs to know about the container and the controller at the same time.

]]> By: Shane Courtrille http://elegantcode.com/2008/12/13/the-importance-of-releasing-your-components-through-windsor/comment-page-1/#comment-39592 Shane Courtrille Sat, 13 Dec 2008 15:43:20 +0000 http://elegantcode.com/?p=1686#comment-39592 This seems like something that shouldn't be your responsibility. It would be nice if there was a LifeCycle that told Windsor to use a WeakReference for keeping track of things so they could be collected properly. This seems like something that shouldn’t be your responsibility. It would be nice if there was a LifeCycle that told Windsor to use a WeakReference for keeping track of things so they could be collected properly.

]]>